[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#53355: guix shell --check: confusing error message
From: |
Chris Marusich |
Subject: |
bug#53355: guix shell --check: confusing error message |
Date: |
Sun, 19 Jun 2022 13:40:50 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi Ludo,
Thank you for the review!
Ludovic Courtès <ludo@gnu.org> writes:
> LGTM, please push!
Before pushing, I did some more tests to make sure it was still working.
When I did this, I noticed that read-line was no longer returning
strings that end in "\r". This prevents child-shell-environment from
behaving correctly, since it incorrectly assumes that all the lines end
in "\r", stripping it off unconditionally. In the past, I'm sure
read-line was returning strings that end in "\r". I don't know what
changed, but I've attached a second patch that fixes this issue, also.
Unless you have more feedback, I'll go ahead and push both patches to
master in a few days.
--
Chris
PGP: https://savannah.gnu.org/people/viewgpg.php?user_id=106836
0001-environment-Don-t-assume-that-lines-have-a-trailing-.patch
Description: Text Data
signature.asc
Description: PGP signature