|
From: | Jim Meyering |
Subject: | Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length |
Date: | Tue, 29 Nov 2011 22:57:32 +0100 |
Paul Eggert wrote: > On 11/29/11 13:38, Jim Meyering wrote: > >> -#define TYPE_IS_INTEGER(t) ((t) 1.5 == 1) >> +#define TYPE_IS_INTEGER(t) ((t) 1.5F == 1) > > I'd rather omit this. The constant is represented exactly and is an > immediate operand of a cast. (And I wouldn't be surprised if some > compilers warned about the "F" for that reason....) If GCC is warning > about this, that's more of a GCC bug than anything else. > > I second Eric's other comments about the changes. I agree.
[Prev in Thread] | Current Thread | [Next in Thread] |