Re: [PATCH v3] gzip: add "--keep" option to keep (don't delete) input files

[Antonio Diaz Diaz]

Rodrigo Campos wrote:
> Not sure I follow you. If "--stdout" is used, keep is set to true (or to 1 :))

Yes, but using --stdout is not the only way of setting to_stdout to 
true. --list, for example, sets to_stdout to true but does not set keep.

Then you made the change

-    if (!to_stdout)
+    if (!keep)

removing to_stdout from the condition. So I guess "gzip --list file" 
will now delete "file".


> So the unlink is only done when keep is false. And that never happens if
> "--stdout" is used, or if "--keep" is used.
>
> Am I missing something ?

Yes, that to_stdout is a global variable set to true in more than one 
place. Not only when --stdout is used.


Regards,
Antonio.