[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: memory leak in dir-lookup found
From: |
Marcus Brinkmann |
Subject: |
Re: memory leak in dir-lookup found |
Date: |
Wed, 28 Mar 2001 22:04:27 +0200 |
User-agent: |
Mutt/1.3.15i |
On Wed, Mar 28, 2001 at 02:33:16PM -0500, Roland McGrath wrote:
> Thanks for tracking this down, Marcus. I would be inclined to change the
> interface so that make_protid consumes the iouser and callers must use dup.
> It is simpler and more concise code just to call dup in the arglist.
Makes sense to me.
> Note that make_protid should check for a null pointer and treat it as ENOMEM.
Uhm. There is a problem with that: Some callers (boot-start.c.
init-startup.c) pass a 0 to make finish_protid to create a iouser for root.
Marcus
--
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann GNU http://www.gnu.org marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de