return value of get_privileged_ports

[Marcus Brinkmann]

Hi,

in glibc:/hurd/privports.c:

kern_return_t
__get_privileged_ports (host_priv_t *host_priv_ptr,
                        device_t *device_master_ptr)
{
  if (! _hurd_host_priv)
    {
      error_t err;

...

Shouldn't this return error_t rather than kern_return_t? As far as I can
see, the kern_return_t blends seamlessly with the glibc error type, which
justifies the use of error_t in the function above in the first place.
(Do we also benefit from symbolic values in the debugger when using error_t
here? I am looking at the end of sysdeps/mach/hurd/errnos.awk)

Also for consistency: It seems kern_return_t is only used where RPCs are
defined. (with maybe an exception profil_task_get_sampled_pcs in
sysdeps/mach/hurd/profil.c, not sure).

Thanks,
Marcus

-- 
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de