[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] ext2fs: free inode warnings
From: |
Neal H Walfield |
Subject: |
Re: [patch] ext2fs: free inode warnings |
Date: |
Sat, 4 Aug 2001 13:19:45 +0200 |
User-agent: |
Mutt/1.3.18i |
> Ok, I've gotten tired of the free inode warnings that ext2fs
> displays if you use a partition in both Linux and HURD. I've
> read the thread on this list from late June, so I know they
> are mostly harmless[1]. Jeff wanted to configure them out of
> existence[2], but I took a different approach and added a
> command-line variable, with the intention of that variable
> controlling any future hurd-specific warnings as well.
I do not think that this is the correct approach, however:
> diff -r -u hurd-20010718.orig/ext2fs/ext2fs.c hurd-20010718/ext2fs/ext2fs.c
Use -p so we can see the function names.
> + case 'H':
> + _hurd_warnings = ENABLED;
> + break;
Do not use variables that start with an _. There are reserved for
system applications.
> +/* ---------------------------------------------------------------- */
> +/* hurd specific features */
> +
> +#define DISABLED 0
> +#define ENABLED 1
I feel that it is better to make the assumption that 0 is false and
!false is true.
pgp7RNHbGpZf9.pgp
Description: PGP signature