Re: zealous use of error

[Thomas Bushnell, BSG]

James Morrison <rocketmail_com@rocketmail.com> writes:

>  Previously netfs_make_protid set errno, no matter what.  So to keep this
> behaviour the patch would look like this.

There is no need to always set errno (though you should check all the
callers to make sure--which needed to be done first anyway).

Assuming all the callers are happy, I think it should only set errno
on an actual error return, and otherwise leave errno alone.

Indeed, if there are callers that depend on it clearing errno, I'd
rather see them fixed.