[patch #2957] HURD_IHASH_ITERATE can loop infinitely

[Marcus Brinkmann]

This mail is an automated notification from the patch tracker
 of the project: The GNU Hurd.

/**************************************************************************/
[patch #2957] Latest Modifications:

Changes by: 
                Marcus Brinkmann <marcus@gnu.org>
'Date: 
                Wed 04/21/04 at 21:39 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
         Assigned to | None                      | marcus
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Thanks for the report.

I made the change, but because I originally thought it was a bug report rather 
than a patch, I didn't check first and thus the changelog entry differs (the 
change is identical to yours, though).

2004-04-21  Marcus Brinkmann  <marcus@gnu.org>
                                                                                
        * ihash.h (HURD_IHASH_ITERATE): Don't use increment operator in
        assignment, but just add one.  Reported by Ognyan Kulev.

In any case, good catch!

Thanks,
Marcus







/**************************************************************************/
[patch #2957] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=2957>
Project: The GNU Hurd
Submitted by: Ognyan Kulev
On: Wed 04/21/04 at 19:46

Category:  libihash
Priority:  7 - High
Resolution:  Fixed
Assigned to:  marcus
Originator Email:  
Status:  Closed


Summary:  HURD_IHASH_ITERATE can loop infinitely

Original Submission:  For advancing _hurd_ihash_valuep, the following pattern 
is used: v=v++. This can loop inifinitely, depending on the mood of the 
compiler. It should be v=v+1.

Follow-up Comments
------------------


-------------------------------------------------------
Date: Wed 04/21/04 at 21:39         By: marcus
Thanks for the report.

I made the change, but because I originally thought it was a bug report rather 
than a patch, I didn't check first and thus the changelog entry differs (the 
change is identical to yours, though).

2004-04-21  Marcus Brinkmann  <marcus@gnu.org>
                                                                                
        * ihash.h (HURD_IHASH_ITERATE): Don't use increment operator in
        assignment, but just add one.  Reported by Ognyan Kulev.

In any case, good catch!

Thanks,
Marcus







File Attachments
-------------------

-------------------------------------------------------
Date: Wed 04/21/04 at 19:46  Name: ihash.patch  Size: 631KB   By: ogi
Patch
http://savannah.gnu.org/patch/download.php?item_id=2957&amp;item_file_id=3130






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=2957>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/