[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GCC 3.4 fixes and small io_seek fix
From: |
Roland McGrath |
Subject: |
Re: GCC 3.4 fixes and small io_seek fix |
Date: |
Fri, 7 May 2004 17:39:34 -0400 (EDT) |
> + (void)0; /* Silence GCC error. */
Just use "break;" here (or ";" if not in a loop/switch), and no comment.
> - /* CHECKSUM_UNNECESSARY */
> + break; /* CHECKSUM_UNNECESSARY */
Just insert the new line, don't modify the old line.
> + if (pos < 0)
> + err = EINVAL;
> +
> if (! err)
> - *new_offs = op->offs;
> + *new_offs = op->offs = pos;
Use else.