[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Making the hurd console accessible to blind users
From: |
Samuel Thibault |
Subject: |
Re: Making the hurd console accessible to blind users |
Date: |
Sat, 5 Mar 2005 20:30:02 +0100 |
User-agent: |
Mutt/1.5.6i-nntp |
Marco Gerards, le sam 05 mar 2005 19:33:26 +0100, a dit :
> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
>
> > Samuel Thibault, on sat 05 mar 2005 17:00:32 +0100, wrote:
> >> here is a patch to extend Marco's console repeater translator
> >
> > I made very few corrections (in trans.c:netfs_attempt_mkfile() and
> > vcs-repeat.c:vcs_read(), namely), latest version is available at
> > http://perso.ens-lyon.fr/samuel.thibault/patch-console-client
>
> You are checking the return value of alloca. AFAIK alloca can not
> fail (or better: only silently) so perhaps it is better to either
> remove this check or use malloc.
Ah, the french manpage is not up to date... (I'll really endup with
alias man='LANG= man' someday...). I have removed the check.
> On IRC we talked about this patch, but no one knew for sure if the
> lock in netfs_attempt_mkfile was on the right place. Can someone
> people have a look at this?
At least the corrected version is on the safe side: after checking the
permission on the directory, there is no need for dir any more.
Regards,
Samuel Thibault