[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnumach ChangeLog linux/dev/glue/block.c [gnumach-1-branch]
|
From: |
Samuel Thibault |
|
Subject: |
Re: gnumach ChangeLog linux/dev/glue/block.c [gnumach-1-branch] |
|
Date: |
Thu, 1 Mar 2007 02:09:43 +0100 |
|
User-agent: |
Mutt/1.5.12-2006-07-14 |
Hi,
Thomas Schwinge, le Wed 28 Feb 2007 01:36:53 +0100, a écrit :
> > * linux/dev/glue/block.c (free_buffer): Fix
> > vm_page_lock_queues/vm_page_unlock_queues pair.
>
> Nice catch! Did you hit this problem somehow or just spotted it by
> looking at the code?
I was looking at the code so as to understand how I was supposed to to
things in the Xen branch :)
> Wouldn't it make sense to use `vm/vm_page''s `VM_PAGE_FREE' macro for
> that one and also in a number of other places? I could change that.
Ah, yes indeed.
Samuel