Re: Bug#413787: libc0.3: TLS patch

[Samuel Thibault]

Hi,

Thomas Schwinge, le Wed 07 Mar 2007 19:49:15 +0100, a écrit :
> The Jeroen patch (<http://www.dekkers.cx/hurd/glibc-tls.patch>)...

Ah, missed it.

> #v+
> Index: sysdeps/mach/hurd/dl-sysdep.c
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/mach/hurd/dl-sysdep.c,v
> retrieving revision 1.78
> diff -u -p -r1.78 dl-sysdep.c
> --- sysdeps/mach/hurd/dl-sysdep.c     6 Sep 2004 21:31:38 -0000       1.78
> +++ sysdeps/mach/hurd/dl-sysdep.c     18 Sep 2005 13:34:50 -0000
> @@ -63,8 +63,10 @@ hp_timing_t _dl_cpuclock_offset;
>  struct hurd_startup_data *_dl_hurd_data;
>  
>  /* This is used only within ld.so, via dl-minimal.c's __errno_location.  */
> +#ifndef USE___THREAD
>  #undef errno
>  int errno attribute_hidden;
> +#endif

Mmm, on the Hurd, errno is still not a __thread var yet.

> Index: sysdeps/mach/hurd/fork.c
> ===================================================================
> RCS file: /cvs/glibc/libc/sysdeps/mach/hurd/fork.c,v
> retrieving revision 1.56
> diff -u -p -r1.56 fork.c
> --- sysdeps/mach/hurd/fork.c  27 Oct 2004 07:47:10 -0000      1.56
> +++ sysdeps/mach/hurd/fork.c  18 Sep 2005 13:34:51 -0000
> @@ -537,7 +537,7 @@ __fork (void)
>       LOSE;
>  #endif
>  
> -      if (err = __thread_set_state (thread, MACHINE_THREAD_STATE_FLAVOR,
> +      if (err = __thread_set_state (thread, i386_REGS_SEGS_STATE,
>                                   (natural_t *) &state, statecount))
>       LOSE;

This I don't know.

Samuel