[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: The patch of boot to open a virtual network interface
From: |
Ben Asselstine |
Subject: |
Re: The patch of boot to open a virtual network interface |
Date: |
Wed, 20 Aug 2008 20:30:42 -0400 |
On Tue, Aug 19, 2008 at 4:02 PM, zhengda <zhengda1936@gmail.com> wrote:
>
> + case 'f':
> + dev_file = strstr (arg, "=");
> + if (dev_file == NULL)
> + return ARGP_ERR_UNKNOWN;
> + *dev_file = 0;
> + add_dev_map (arg, dev_file+1);
> + break;
I'd feel better about this patch if it used a long option --device
instead of the short option -f.
Also, the use of strstr is pernicious.
Ben
- Re: The patch of boot to open a virtual network interface, (continued)
- Re: The patch of boot to open a virtual network interface, zhengda, 2008/08/19
- Re: The patch of boot to open a virtual network interface, Neal H. Walfield, 2008/08/19
- Re: The patch of boot to open a virtual network interface, zhengda, 2008/08/19
- Re: The patch of boot to open a virtual network interface, zhengda, 2008/08/19
- Re: The patch of boot to open a virtual network interface,
Ben Asselstine <=
- Re: The patch of boot to open a virtual network interface, zhengda, 2008/08/21
- Re: The patch of boot to open a virtual network interface, olafBuddenhagen, 2008/08/21
- Re: The patch of boot to open a virtual network interface, Da Zheng, 2008/08/22
- Re: The patch of boot to open a virtual network interface, Samuel Thibault, 2008/08/22
- Re: The patch of boot to open a virtual network interface, Ben Asselstine, 2008/08/22
- Re: The patch of boot to open a virtual network interface, Samuel Thibault, 2008/08/22
- Re: The patch of boot to open a virtual network interface, olafBuddenhagen, 2008/08/25
- Re: The patch of boot to open a virtual network interface, Da Zheng, 2008/08/26
The patch of boot to open a virtual network interface, zhengda, 2008/08/08