Re: [PATCH] Fix the ``--priority'' option handling in netfs_append_args.

[Sergiu Ivanov]

Hello,

On Tue, Aug 11, 2009 at 11:49:03AM +0200, Thomas Schwinge wrote:
> On Tue, Aug 11, 2009 at 12:03:59AM +0300, Sergiu Ivanov wrote:
> > * netfs.c (netfs_append_args): Change the format specification
> > to ``%d''.
> 
> OK for master, but please use ``* netfs.c (netfs_append_args) <priority>:
> Change the...'' to indicate that only the priority value handling was
> affected.

I changed that and will commit it to master as soon as I we have
finished correcting the patch about syncing unionfs.
 
> > I've been looking at this gcc warning for about a year, but I though
> > it was some secret plan of the creator of unionfs, until I ran into
> > some memory corruption due to this bug.
> 
> Yo, fixing compiler warnings is always a good idea.  Not only in unionfs
> code.  At some point we may consider -Werror.

Great :-) -Werror will push the code towards perfection :-)

Regards,
scolobb