[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Implement the sync libnetfs stubs.
From: |
Sergiu Ivanov |
Subject: |
Re: [PATCH] Implement the sync libnetfs stubs. |
Date: |
Mon, 17 Aug 2009 23:49:38 +0300 |
User-agent: |
Mutt/1.5.16 (2007-06-09) |
Hello,
On Sun, Aug 16, 2009 at 08:57:46PM +0200, olafBuddenhagen@gmx.net wrote:
>
> I know that my reviews are too pedantic at times -- partially on
> purpose, trying to establish some good practices; partially because of
> my annoying perfectionism. But here I didn't just talk about formalities
> like variable names or comments, but raised a fundamental concern!
I can acknowledge that in this instance of GSoC I learned very much
about good coding standards through paying as much attention as I
could to all the comments my patches received :-)
> > I assume that you can confirm in some way (testing, staring at the
> > code, ...) that it does the correct thing. And should there be any
> > breakage, and we discover it later on, we'll repair it later on.
>
> The correct functioning of filesystem syncing is very hard to test; and
> any errors will be extremely hard to track down later on. Which makes it
> all the more important that we be able to say with some confidence that
> the code is really doing the right thing.
Is there a good way to test syncing? I tried outputting debug
messages to see if everything ends normally, but I cannot shake off
the feeling that this is not really sufficient.
Regards,
scolobb