[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
nsmux: Build system
From: |
Sergiu Ivanov |
Subject: |
nsmux: Build system |
Date: |
Sun, 25 Oct 2009 18:13:47 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hello,
On Sat, Oct 24, 2009 at 06:51:57AM +0200, olafBuddenhagen@gmx.net wrote:
> On Wed, Sep 30, 2009 at 02:35:14PM +0300, Sergiu Ivanov wrote:
> > On Tue, Sep 22, 2009 at 01:40:29AM +0200, olafBuddenhagen@gmx.net
> > wrote:
>
> > > Of course, you also need to adapt the build system somewhere along
> > > the way...
> >
> > Which way would be preferred: adapting the build system before the
> > merge of after the merge?
> >
> > I'd stand for the ``before the merge'' variant, since the current
> > ``build system'' is actually a one-liner bash script invoking gcc.
>
> Either before the merge, so you can test it by moving the existing
> repository to a subdirectory in the hurd/ tree and test it there; or
> directly in the merge process, without an extra commit for the build
> system change alone. Not sure which is better really.
I think I have an extra argument for the second way: if I create a
separate commit before the merge, things will stop working, and, as
you once said, a commit is a set of changes after which everything
works :-)
What do you say?
Regards,
scolobb