Re: review of modifications of eth-multiplexer

[olafBuddenhagen]

Hi,

On Tue, Dec 22, 2009 at 07:51:35PM +0800, Da Zheng wrote:

> > You can find the patches in the bug-hurd mailing list archives:
> > 
> > http://lists.gnu.org/archive/html/bug-hurd/2009-08/msg00056.html
> > http://lists.gnu.org/archive/html/bug-hurd/2009-08/msg00053.html

> I think your patch is good:-)

Well, which one?... These links reference a total of three different
patches. One of them ("Fix some minor issues") definitely needs changes,
and I did already give some feedback (though hampered by my limited
understanding); but didn't get around to follow up on it so far.

The other two ("Setup the node stat information in netfs_validate_stat"
and "Add the .MASTER node to the eth-multiplexer") I didn't comment on
at all, as I don't know enough about eth-multiplexer to really
understand the changes...

Would be nice if you could look at all three patches, and also the
discussion on the "minor issues" one.

-antrik-