[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] Add a new exec_exec_file_name RPC
From: |
Carl Fredrik Hammar |
Subject: |
Re: [PATCH 1/3] Add a new exec_exec_file_name RPC |
Date: |
Mon, 19 Jul 2010 10:34:49 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
Hi,
On Fri, Jul 16, 2010 at 12:13:56PM +0200, Emilio Pozuelo Monfort wrote:
> On 31/05/10 18:27, Carl Fredrik Hammar wrote:
> > I have reviewed the patches and apart from formatting there were only
> > a couple of issues. Next iteration is hopefully the last.
>
> I hope so!
Almost. :-)
The biggest problem is that your mail agent corrupts the patches
by breaking long lines (can't believe I didn't spot this sooner).
Please test this before resending the patches by mailing yourself and
and git am the patches. As to actual content it's mostly just about
the commit messages.
> >From 48515284b0f876094d50bfd6a7825b8815f125b8 Mon Sep 17 00:00:00 2001
> From: Emilio Pozuelo Monfort <pochu27@gmail.com>
> Date: Wed, 26 May 2010 00:15:37 +0200
> Subject: [PATCH 1/3] Add a new exec_exec_file_name RPC
>
> * hurd/exec.defs (exec_exec_file_name): New RPC.
> (exec_exec): Label as deprecated.
> * doc/hurd.texi: Updated.
> * exec/exec.c (S_exec_exec_file_name): New function.
> (S_exec_exec): Label as deprecated.
> (do_exec): Add argument.
> * exec/hashexec.c (check_hashbang): Add argument.
> Don't guess the file name if file_name_exec is set.
> * exec/priv.h (check_hashbang): Add argument.
> * hurd/version.h (HURD_INTERFACE_VERSION): Bump version.
You should not have leading tabs in a Hurd commit message ChangeLog.
HURD_INTERFACE_VERSION shouldn't be in this patch.
> index 9b85b5a..fd7847d 100644
> --- a/hurd/version.h
> +++ b/hurd/version.h
> @@ -3,4 +3,4 @@
> and will only ever be increased. This will be bumped whenever either
> the RPC interfaces or the library APIs change. */
>
> -#define HURD_INTERFACE_VERSION 20020609
> +#define HURD_INTERFACE_VERSION 20100527
You forgot to remove this. Otherwise the patch is fine.
Regards,
Fredrik