[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/8] Add missing functions to input_driver_test.
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 6/8] Add missing functions to input_driver_test. |
Date: |
Fri, 13 Aug 2010 14:59:49 +0200 |
User-agent: |
Mutt/1.5.12-2006-07-14 |
olafBuddenhagen@gmx.net, le Wed 11 Aug 2010 07:59:13 +0200, a écrit :
> On Wed, Aug 04, 2010 at 04:20:04AM -0300, Diego Nieto Cid wrote:
>
> > +void console_switch_back(void)
> > +{
> > + puts("Switch back\n");
>
> Hm... I'm slightly ambivalent about the use of puts(). It make a lot of
> sense technically in this case; and now that I think about it, I wonder
> why it isn't used much more often...
>
> However, as all the other code in this file uses printf() for this
> purpose, I tend to think that it might be better to stick to that for
> consistency?
gcc optimizes it into a call to puts anyway :)
Samuel
- [PATCH 4/8] Remove glue code and use mig to regenerate it., (continued)
- [PATCH 5/8] Update code borrowed from console-client., Diego Nieto Cid, 2010/08/04
- [PATCH 6/8] Add missing functions to input_driver_test., Diego Nieto Cid, 2010/08/04
- [PATCH 7/8] Argument's default values are set independently., Diego Nieto Cid, 2010/08/04
- [PATCH 8/8] Use vfprintf in debug_printf and write to stderr., Diego Nieto Cid, 2010/08/04
- Re: [PATCH 0/8] Bring console-driver-xkb up to date, olafBuddenhagen, 2010/08/11
Re: [PATCH 0/8] Bring console-driver-xkb up to date, Samuel Thibault, 2010/08/17