[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH.HURD] Limit the minimum timeout delay to 1us for hurdselect.c
From: |
Samuel Thibault |
Subject: |
Re: [PATCH.HURD] Limit the minimum timeout delay to 1us for hurdselect.c to avoid problems |
Date: |
Thu, 1 Nov 2012 17:44:28 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Svante Signell, le Thu 01 Nov 2012 17:32:53 +0100, a écrit :
> --- ../hurdselect_orig.c 2012-10-21 22:55:26.000000000 +0200
> +++ ../hurdselect_orig_timeout.c 2012-11-01 12:58:00.000000000 +0100
> @@ -84,9 +84,13 @@
>
> to = (timeout->tv_sec * 1000 +
> (timeout->tv_nsec + 999999) / 1000000);
> - if (strcmp(program_invocation_short_name, "vi") &&
> strcmp(program_invocation_short_name, "vim") &&
> strcmp(program_invocation_short_name, "vimdiff") && !to)
> - to = 1;
> }
> + /* XXX: A timeout of 0 returns immediately, even if no file
> + descriptors are ready. This is correct according to
> + POSIX.1-2001. As many programs rely on file descriptors being
> + ready for a timeout of zero use 1 msec as the minimum delay */
> + if (to == 0)
> + to = 1;
Nack. We've already tried that in the past, and and using even just 1
makes some applications sluggish like hell. See the archive list for
the current work on actually fixing the issue properly, i.e. adding a
file server interface for probing.
Samuel