[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: console-client/xkb/compose.c (read_composefile): fclose
|
From: |
Samuel Thibault |
|
Subject: |
Re: console-client/xkb/compose.c (read_composefile): fclose |
|
Date: |
Sat, 1 Jun 2013 19:13:01 +0200 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Miguel Figueiredo, le Sat 01 Jun 2013 11:05:10 +0100, a écrit :
> 2013-06-01 Miguel Figueiredo <elmig@debianpt.org>
>
> * console-client/xkb/compose.c (read_composefile): fclose
>
> iiuc parse_composefile always returns 0 and this makes the if(err) not
> executing the fclose.
> cppcheck reported this as memory leak.
Applied, thanks.
> diff --git a/console-client/trans.c b/console-client/trans.c
> index 6949af5..8219f97 100644
> --- a/console-client/trans.c
> +++ b/console-client/trans.c
> @@ -844,7 +844,6 @@ console_unregister_consnode (consnode_t cn)
> error_t
> console_setup_node (char *path)
> {
> - mach_port_t underlying;
> mach_port_t bootstrap;
> error_t err;
> struct stat ul_stat;
Always proofread the patch you are sending for spurious changes :)
Samuel