[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Gracefully handle errors using argp_error().
From: |
Justus Winter |
Subject: |
Re: [PATCH] Gracefully handle errors using argp_error(). |
Date: |
Fri, 05 Jul 2013 09:33:59 +0200 |
User-agent: |
alot/0.3.4 |
Hi :),
Quoting Cyril Roelandt (2013-07-05 01:25:26)
> Hello!
>
> After seeing this patch from Justus Winter:
>
> http://lists.gnu.org/archive/html/bug-hurd/2013-06/msg00120.html
>
> I wrote a Coccinelle script that finds similar errors:
Coccinelle is quite awesome :) we should try to find port leaks with
it...
> <smpl>
> [...]
> - error(...,
> + argp_error(state,
^ coding convention says there should be a space there
> E);
> ...>
> }
> </smpl>
>
> I found 4 programs that could be improved by gracefully handling errors
> using argp_error: notice (hurd-extras), mboxfs (hurd-extras), tarfs
> (incubator) and unionfs. The patches are attached.
In your patches the variable state is misspelled sate. How did that
happen? Your script doesn't seem to include the typo.
Cheers,
Justus
signature.asc
Description: signature