Re: [PATCH 3/5] exec: Remove #ifdef 0-out code doing nothing.

[Samuel Thibault]

Justus Winter, le Thu 15 Aug 2013 18:41:52 +0200, a écrit :
> exec/exec.c (load_section): Remove unused code.

> -#if 0
> -     switch (elf_machine)
> -       {
> -       case EM_386:
> -       case EM_486:
> -         /* On the i386, programs normally load at 0x08000000, and
> -            expect their data segment to be able to grow dynamically
> -            upward from its start near that address.  We need to make
> -            sure that the dynamic linker is not mapped in a conflicting
> -            address.  */
> -         /* mask = 0xf8000000UL; */ /* XXX */
> -         break;
> -       default:
> -         break;
> -       }
> -#endif

Mmm, the comment still looks valid to me.  I don't know what else would
make sure the dynamic linker doesn't put anything where libc expects to
be putting its heap.  We need to make sure something does that before
dropping such a scary warning.

Samuel