[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into norma
From: |
Justus Winter |
Subject: |
Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions |
Date: |
Sat, 09 Nov 2013 14:17:54 +0100 |
User-agent: |
alot/0.3.4 |
Hi :)
Quoting Richard Braun (2013-11-09 14:00:35)
> On Sat, Nov 09, 2013 at 11:08:28AM +0100, Justus Winter wrote:
> > Quoting Ludovic =?utf-8?Q?Court=C3=A8s?= (2013-11-09 00:31:08)
> > > Justus Winter <4winter@informatik.uni-hamburg.de> skribis:
> > >
> > > > rebuild_uname uses {init,add}str to incrementally build a version
> > > > string, and compare_versions to sort the versions array. Previously
> > > > those functions were defined as nested functions.
> > >
> > > Isn’t this a bit controversial given the discussion on that topic? :-)
> >
> > Were we having the same discussion? I count Samuel, Richard and me in
> > favor of that kind of change, Roland and you against it.
>
> It's not a matter of mere numbers. We need consensus, and if we can't
> achieve it, the actual maintainer (who currently is Samuel) decides.
I didn't mean to imply that. But given how the discussion was going
(or not), I think it's reasonable to propose the change. By doing so,
I hope to demonstrate that I care enough to do it, how invasive such a
change might be, and what possible benefits might arise from such
changes.
And even if the transformations are not merged, the fixups in this
series can be.
Justus
- [PATCH 14/14] mach-defpager: remove unused variables, (continued)
- [PATCH 14/14] mach-defpager: remove unused variables, Justus Winter, 2013/11/08
- [PATCH 04/14] proc: turn count_up and store_pid into normal functions, Justus Winter, 2013/11/08
- [PATCH 09/14] proc: fix error handling in S_proc_exception_raise, Justus Winter, 2013/11/08
- [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Justus Winter, 2013/11/08
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Ludovic Courtès, 2013/11/08
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Justus Winter, 2013/11/09
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Richard Braun, 2013/11/09
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions,
Justus Winter <=
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Ludovic Courtès, 2013/11/09
- Re: [PATCH 06/14] proc: turn {init, add}str, compare_versions into normal functions, Samuel Thibault, 2013/11/09
[PATCH 03/14] proc: remove declaration of nested functions from proc.h, Justus Winter, 2013/11/08
[PATCH 05/14] proc: turn reap into a normal function, Justus Winter, 2013/11/08
[PATCH 08/14] proc: fix a use-after-free error, Justus Winter, 2013/11/08
[PATCH 13/14] mach-defpager: include errno.h, Justus Winter, 2013/11/08
[PATCH 02/14] libtrivfs: improve the out of memory handling in add_el, Justus Winter, 2013/11/08