[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_S
From: |
Guillem Jover |
Subject: |
Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP |
Date: |
Wed, 20 Nov 2013 21:09:08 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi!
On Wed, 2013-11-20 at 13:53:51 +0100, Marin Ramesa wrote:
> diff --git a/ddb/db_run.c b/ddb/db_run.c
> index 22cd358..60b34bf 100644
> --- a/ddb/db_run.c
> +++ b/ddb/db_run.c
> @@ -171,7 +171,7 @@ db_restart_at_pc(watchpt, task)
> boolean_t watchpt;
> task_t task;
> {
> - db_addr_t pc = PC_REGS(DDB_REGS), brpc;
> + db_addr_t pc = PC_REGS(DDB_REGS);
>
> if ((db_run_mode == STEP_COUNT) ||
> (db_run_mode == STEP_RETURN) ||
> @@ -187,6 +187,7 @@ db_restart_at_pc(watchpt, task)
> db_load_count += inst_load(ins);
> db_store_count += inst_store(ins);
> #ifdef SOFTWARE_SSTEP
> + db_addr_t brpc;
> /* Account for instructions in delay slots */
> brpc = next_instr_address(pc, 1, task);
> if ((brpc != pc) && (inst_branch(ins) || inst_call(ins))) {
This adds intermixing of statements and declarations.
Thanks,
Guillem
- Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, (continued)
- Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Guillem Jover, 2013/11/20
- Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Marin Ramesa, 2013/11/20
- Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Samuel Thibault, 2013/11/20
- Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Marin Ramesa, 2013/11/20
- Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Samuel Thibault, 2013/11/20
- Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Marin Ramesa, 2013/11/20
[PATCH 06/19] ddb: fix implicit declaration of function, Marin Ramesa, 2013/11/20
[PATCH 07/19] ddb/db_run.c: remove set but unused variable, Marin Ramesa, 2013/11/20
[PATCH 08/19] ddb/db_run.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/11/20
[PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP, Marin Ramesa, 2013/11/20
- Re: [PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP,
Guillem Jover <=
[PATCH 10/19] ddb/db_sym.c: add parentheses around assignment used as truth value, Marin Ramesa, 2013/11/20
[PATCH 11/19] ddb/db_variables.c: fix initializations from incompatible pointer type, Marin Ramesa, 2013/11/20
[PATCH 12/19] ipc/ipc_print.h: include ipc/ipc_pset.h for ipc_pset_t, Marin Ramesa, 2013/11/20
[PATCH 13/19] kern/startup.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20