[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name
From: |
Marin Ramesa |
Subject: |
Re: [PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name |
Date: |
Wed, 20 Nov 2013 21:31:33 +0100 |
On 20.11.2013 21:19:24, Guillem Jover wrote:
> On Wed, 2013-11-20 at 13:53:47 +0100, Marin Ramesa wrote:
> > * ddb/db_expr.h (db_expression): Remove (db_addr_t *) argument
> name.
>
> Do you mean db_expr_t?
No, (db_addr_t *).
> > ---
> > ddb/db_expr.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/ddb/db_expr.h b/ddb/db_expr.h
> > index 989b66b..6a24ccd 100644
> > --- a/ddb/db_expr.h
> > +++ b/ddb/db_expr.h
> > @@ -21,6 +21,6 @@ int db_size_option(
> > boolean_t *u_option,
> > boolean_t *t_option);
> >
> > -int db_expression(db_expr_t *valuep);
> > +int db_expression(db_expr_t *);
>
> Why?
It seems there is a collision in names somewhere where db_expr.h is
included. valuep is a pointer to db_addr_t.
- Re: [PATCH 01/19] ddb: fix implicit declaration of functions, (continued)
[PATCH 04/19] ddb/db_examine.c: fix signedness, Marin Ramesa, 2013/11/20
[PATCH 05/19] ddb/db_expr.h: remove (db_addr_t *) argument name, Marin Ramesa, 2013/11/20
[PATCH 06/19] ddb: fix implicit declaration of function, Marin Ramesa, 2013/11/20
[PATCH 07/19] ddb/db_run.c: remove set but unused variable, Marin Ramesa, 2013/11/20
[PATCH 08/19] ddb/db_run.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/11/20
[PATCH 09/19] ddb/db_run.c: move declaration of brpc into SOFTWARE_SSTEP, Marin Ramesa, 2013/11/20