[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/19] i386/i386at/kd.c: add forward declaration
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 17/19] i386/i386at/kd.c: add forward declaration |
Date: |
Wed, 20 Nov 2013 22:14:31 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Wed 20 Nov 2013 21:38:05 +0100, a écrit :
> On 20.11.2013 21:29:06, Guillem Jover wrote:
> > On Wed, 2013-11-20 at 13:53:59 +0100, Marin Ramesa wrote:
> > > diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c
> > > index 3890c3d..a5dff3c 100644
> > > --- a/i386/i386at/kd.c
> > > +++ b/i386/i386at/kd.c
> > > @@ -965,6 +965,9 @@ boolean_t up;
> > > return(state);
> > > }
> > >
> > > +#if MACH_KDB
> > > +extern void kdb_kintr(void); /* forward */
> > > +#endif /* MACH_KDB */
> >
> > Why not add it to a header file?
>
> Is not used that much.
Still. Putting it a header makes properly sure that the caller and the
callee agree on the convention. The number of calls does not matter.
Samuel
- [PATCH 11/19] ddb/db_variables.c: fix initializations from incompatible pointer type, (continued)
- [PATCH 11/19] ddb/db_variables.c: fix initializations from incompatible pointer type, Marin Ramesa, 2013/11/20
- [PATCH 12/19] ipc/ipc_print.h: include ipc/ipc_pset.h for ipc_pset_t, Marin Ramesa, 2013/11/20
- [PATCH 13/19] kern/startup.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20
- [PATCH 14/19] kern/xpr.c: quiet warning about uninitialized variable, Marin Ramesa, 2013/11/20
- [PATCH 15/19] device/net_io.c: quiet the warning about uninitialized variable, Marin Ramesa, 2013/11/20
- [PATCH 16/19] Fix implicit declaration of function, Marin Ramesa, 2013/11/20
- [PATCH 17/19] i386/i386at/kd.c: add forward declaration, Marin Ramesa, 2013/11/20
- [PATCH 18/19] i386/i386/db_interface.c: add forward declaration, Marin Ramesa, 2013/11/20
- [PATCH 19/19] i386/i386/db_interface.c: fix implicit declaration of function, Marin Ramesa, 2013/11/20