[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] ddb/db_mp.c: include kd.h for kdb_kintr()
From: |
Guillem Jover |
Subject: |
Re: [PATCH 1/7] ddb/db_mp.c: include kd.h for kdb_kintr() |
Date: |
Fri, 22 Nov 2013 19:08:53 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, 2013-11-22 at 18:30:34 +0100, Marin Ramesa wrote:
> diff --git a/ddb/db_mp.c b/ddb/db_mp.c
> index 3ab00ce..831381f 100644
> --- a/ddb/db_mp.c
> +++ b/ddb/db_mp.c
> @@ -36,6 +36,8 @@
>
> #include <machine/db_machdep.h>
>
> +#include <i386at/kd.h>
> +
> #include <ddb/db_command.h>
> #include <ddb/db_run.h>
I don't think it's appropriate to include stuff from the <i386at/*>
namespace from ddb/.
Thanks,
Guillem
- [PATCH 1/7] ddb/db_mp.c: include kd.h for kdb_kintr(), Marin Ramesa, 2013/11/22
- [PATCH 2/7] ddb: move forward declarations into a header file, Marin Ramesa, 2013/11/22
- [PATCH 3/7] ddb: create new header file db_mp.h, Marin Ramesa, 2013/11/22
- [PATCH 4/7] ddb: move forward declaration into a header file, Marin Ramesa, 2013/11/22
- [PATCH 5/7] ddb: move forward declarations into a header file, Marin Ramesa, 2013/11/22
- [PATCH 6/7] ddb/db_examine.c: trivial stylistic fix for consistency, Marin Ramesa, 2013/11/22
- [PATCH 7/7] device: new header file chario.h, Marin Ramesa, 2013/11/22
- Re: [PATCH 1/7] ddb/db_mp.c: include kd.h for kdb_kintr(),
Guillem Jover <=