[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_dis
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_disk_pager |
Date: |
Wed, 27 Nov 2013 22:46:27 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Wed 27 Nov 2013 13:31:14 +0100, a écrit :
> * libdiskfs/disk-pager.c (diskfs_start_disk_pager): Improve error reporting.
Better message indeed, ack.
> ---
> libdiskfs/disk-pager.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libdiskfs/disk-pager.c b/libdiskfs/disk-pager.c
> index 8fe8f80..9a0d9d8 100644
> --- a/libdiskfs/disk-pager.c
> +++ b/libdiskfs/disk-pager.c
> @@ -71,7 +71,8 @@ diskfs_start_disk_pager (struct user_pager_info *upi,
> diskfs_disk_pager = pager_create (upi, pager_bucket,
> may_cache, MEMORY_OBJECT_COPY_NONE,
> notify_on_evict);
> - assert (diskfs_disk_pager);
> + if (diskfs_disk_pager == NULL)
> + error (2, errno, "creating diskfs_disk_pager failed");
>
> /* Get a port to the disk pager. */
> disk_pager_port = pager_get_port (diskfs_disk_pager);
> --
> 1.7.10.4
>
--
Samuel
/* Amuse the user. */
printk(
" \\|/ ____ \\|/\n"
" \"@'/ ,. \\`@\"\n"
" /_| \\__/ |_\\\n"
" \\__U_/\n");
(From linux/arch/sparc/kernel/traps.c:die_if_kernel())
- Re: [PATCH 03/11] proc: update comments, (continued)
- [PATCH 04/11] libports: improve error handling in ports_reallocate_port, Justus Winter, 2013/11/27
- [PATCH 02/11] init: fix port leak, Justus Winter, 2013/11/27
- [PATCH 05/11] libports: improve error handling in ports_reallocate_from_external, Justus Winter, 2013/11/27
- [PATCH 06/11] libports: improve error handling in ports_transfer_right, Justus Winter, 2013/11/27
- [PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_disk_pager, Justus Winter, 2013/11/27
- Re: [PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_disk_pager,
Samuel Thibault <=
- [PATCH 10/11] proc: store the privileged host port in _hurd_host_priv, Justus Winter, 2013/11/27
- [PATCH 09/11] libports: improve error reporting in adjust_priority, Justus Winter, 2013/11/27
- [PATCH 08/11] libfshelp: improve error handling in fshelp_start_translator_long, Justus Winter, 2013/11/27
- [PATCH 11/11] proc: store the device master port in _hurd_device_master, Justus Winter, 2013/11/27