[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/13] console-client: remove spurious pthread_spin_unlocks
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 13/13] console-client: remove spurious pthread_spin_unlocks |
Date: |
Tue, 10 Dec 2013 01:17:02 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Mon 09 Dec 2013 15:16:41 +0100, a écrit :
> * console-client/trans.c (netfs_attempt_mkfile): Remove spurious
> pthread_spin_unlock.
> (netfs_node_norefs): Likewise.
It seems completely spurious indeed.
> ---
> console-client/trans.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/console-client/trans.c b/console-client/trans.c
> index 8219f97..00c5407 100644
> --- a/console-client/trans.c
> +++ b/console-client/trans.c
> @@ -482,7 +482,6 @@ netfs_attempt_mkfile (struct iouser *user, struct node
> *dir,
>
> *np = netfs_make_node (nn);
> pthread_mutex_lock (&(*np)->lock);
> - pthread_spin_unlock (&netfs_node_refcnt_lock);
>
> return 0;
> }
> @@ -624,7 +623,6 @@ void netfs_node_norefs (struct node *np)
> if (np->nn->symlink_path)
> free (np->nn->symlink_path);
>
> - pthread_spin_unlock (&netfs_node_refcnt_lock);
> free (np->nn);
> free (np);
> }
> --
> 1.7.10.4
>
--
Samuel
<erno> hm. I've lost a machine.. literally _lost_. it responds to ping, it
works completely, I just can't figure out where in my apartment it is.
- Re: [PATCH 11/13] trans: improve the error handling in fakeauth, (continued)
- [PATCH 09/13] trans: fix locking in fakeroot's netfs_S_dir_lookup, Justus Winter, 2013/12/09
- [PATCH 12/13] trans: unlock nodes with faked attributes in fakeroot, Justus Winter, 2013/12/09
- [PATCH 05/13] trans: handle invalid responses to dir_lookup requests in fakeroot, Justus Winter, 2013/12/09
- [PATCH 10/13] trans: fix reference counting bug in fakeroot, Justus Winter, 2013/12/09
- [PATCH 13/13] console-client: remove spurious pthread_spin_unlocks, Justus Winter, 2013/12/09
- Re: [PATCH 13/13] console-client: remove spurious pthread_spin_unlocks,
Samuel Thibault <=
- Re: More fixes for fakeroot-hurd, Samuel Thibault, 2013/12/09
- [PATCH 1/5] utils/settrans: fix the teardown of chrooted environments, Justus Winter, 2013/12/10