[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] trans/fakeroot: remove dead code
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 5/5] trans/fakeroot: remove dead code |
Date: |
Wed, 11 Dec 2013 00:22:58 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Tue 10 Dec 2013 17:50:30 +0100, a écrit :
> * trans/fakeroot.c (netfs_S_dir_lookup): Remove dead code.
Ack.
> ---
> trans/fakeroot.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/trans/fakeroot.c b/trans/fakeroot.c
> index 58f1112..203f2c1 100644
> --- a/trans/fakeroot.c
> +++ b/trans/fakeroot.c
> @@ -371,10 +371,8 @@ netfs_S_dir_lookup (struct protid *diruser,
> if (err)
> goto lose;
>
> - if (retry_name[0] == '\0' && *do_retry == FS_RETRY_NORMAL)
> - flags &= ~(O_CREAT|O_EXCL|O_NOLINK|O_NOTRANS|O_NONBLOCK);
> - else
> - flags = 0;
> + assert (retry_name[0] == '\0' && *do_retry == FS_RETRY_NORMAL);
> + flags &= ~(O_CREAT|O_EXCL|O_NOLINK|O_NOTRANS|O_NONBLOCK);
>
> err = iohelp_dup_iouser (&user, diruser->user);
> if (!err)
> --
> 1.7.10.4
>
--
Samuel
/*
* Oops. The kernel tried to access some bad page. We'll have to
* terminate things with extreme prejudice.
*/
die_if_kernel("Oops", regs, error_code);
(From linux/arch/i386/mm/fault.c)
- Re: [PATCH 13/13] console-client: remove spurious pthread_spin_unlocks, (continued)
- Re: More fixes for fakeroot-hurd, Samuel Thibault, 2013/12/09
- [PATCH 1/5] utils/settrans: fix the teardown of chrooted environments, Justus Winter, 2013/12/10
- [PATCH 2/5] trans/fakeroot: fix ownership of newly created files, Justus Winter, 2013/12/10
- [PATCH 3/5] trans/fakeroot: drop else, Justus Winter, 2013/12/10
- [PATCH 4/5] trans/fakeroot: remove dead code, Justus Winter, 2013/12/10
- [PATCH 5/5] trans/fakeroot: remove dead code, Justus Winter, 2013/12/10
- Re: [PATCH 5/5] trans/fakeroot: remove dead code,
Samuel Thibault <=
- updated 1st patch, Justus Winter, 2013/12/10
- Re: [PATCH 1/5] utils/settrans: fix the teardown of chrooted environments, Samuel Thibault, 2013/12/10