[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC) |
Date: |
Sun, 15 Dec 2013 21:20:39 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Richard Braun, le Mon 09 Dec 2013 14:10:32 +0100, a écrit :
> On Mon, Dec 09, 2013 at 12:59:33PM +0100, Samuel Thibault wrote:
> > No, it's really commenting c != K_DONE which makes the warning away. My
> > current guess is that c gets implicitly casted to int instead of
> > unsigned int.
>
> Just to make sure, I've switched char_idx and max to unsigned int and
> the warning disappeared.
Hum :)
I guess for some reason commenting c != K_DONE was triggering other
optimization paths, which were not making the assumption at stake.
I have commited make them unsigned then.
Samuel
- Re: [PATCH 14/14] vm/vm_resident.c: move struct definition to a header file, (continued)
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Samuel Thibault, 2013/12/08
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Marin Ramesa, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Richard Braun, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Marin Ramesa, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Richard Braun, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Samuel Thibault, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Richard Braun, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Samuel Thibault, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC), Marin Ramesa, 2013/12/09
- Re: [PATCH 01/14] i386/i386at/kd.c: fix signed overflow (a warning from GCC),
Samuel Thibault <=