[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/11] term: fix memory leak
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 04/11] term: fix memory leak |
Date: |
Fri, 23 May 2014 00:20:30 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Thu 22 May 2014 22:13:26 +0200, a écrit :
> I hope someone fixed that bug.
Well, I guess you ran a box for some time with it?
> * term/users.c (pi_destroy_hook): Fix memory leak.
> ---
> term/users.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/term/users.c b/term/users.c
> index 97bc22c..9bd51d0 100644
> --- a/term/users.c
> +++ b/term/users.c
> @@ -259,9 +259,7 @@ pi_destroy_hook (struct trivfs_protid *cred)
> {
> assert (((struct protid_hook *)cred->hook)->refcnt > 0);
> if (--((struct protid_hook *)cred->hook)->refcnt == 0)
> - /* XXX don't free for now, so we can try and catch a multiple-freeing
> - bug. */
> - /* free (cred->hook) */;
> + free (cred->hook);
> }
> pthread_mutex_unlock (&global_lock);
> }
> --
> 2.0.0.rc2
>
--
Samuel
> [Linux] c'est une philosophie un art de vivre, un état intérieur,
> une sorte de fluide qui nous entoure et nous pénètre.
Fais tourner stp !
-+- Guillaume in Guide du linuxien pervers - "Tous drogués j'vous dis !"
- [PATCH 05/11] libdiskfs: fix type of dir_cache_id, node_cache_id, (continued)
- [PATCH 08/11] libdiskfs: add diskfs_make_node_alloc to allocate fat nodes, Justus Winter, 2014/05/22
- [PATCH 04/11] term: fix memory leak, Justus Winter, 2014/05/22
- Re: [PATCH 04/11] term: fix memory leak,
Samuel Thibault <=
- [PATCH 10/11] trans/fakeroot: use fat nodes to simplify the node cache, Justus Winter, 2014/05/22
- [PATCH 11/11] trans/fakeroot: use netfs_node_netnode instead of np->nn, Justus Winter, 2014/05/22
- Re: [PATCH 01/11] include: install refcount.h, Samuel Thibault, 2014/05/22