Re: [PATCH hurd 1/7] libfshelp: improve error handling

[Samuel Thibault]

Justus Winter, le Sat 17 Jan 2015 18:26:40 +0100, a écrit :
> * libfshelp/start-translator-long.c (fshelp_start_translator_long):
> Once we have a task, go to `lose_task' so that we do not leave hosed
> tasks around.

Ack, thanks!

> ---
>  libfshelp/start-translator-long.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libfshelp/start-translator-long.c 
> b/libfshelp/start-translator-long.c
> index 64a20be..8b00e08 100644
> --- a/libfshelp/start-translator-long.c
> +++ b/libfshelp/start-translator-long.c
> @@ -232,7 +232,7 @@ fshelp_start_translator_long (fshelp_open_fn_t 
> underlying_open_fn,
>    err = task_priority(task, 25, FALSE);
>  
>    if (err)
> -    goto lose;
> +    goto lose_task;
>  
>    /* Designate TASK as our child and set it's owner accordingly. */
>    proc = getproc ();
> @@ -240,11 +240,11 @@ fshelp_start_translator_long (fshelp_open_fn_t 
> underlying_open_fn,
>    err = proc_task2proc (proc, task, &childproc);
>    mach_port_deallocate (mach_task_self (), proc);
>    if (err)
> -    goto lose;
> +    goto lose_task;
>    err = proc_setowner (childproc, owner_uid, owner_uid == (uid_t) -1);
>    mach_port_deallocate (mach_task_self (), childproc);
>    if (err)
> -    goto lose;
> +    goto lose_task;
>  
>    assert (ports_len > INIT_PORT_BOOTSTRAP);
>    switch (ports_type)
> -- 
> 2.1.4
> 

-- 
Samuel
* x remarque qu'avec un peu de volonté, on peut faire du code de porc
dans d'importe quel langage Turing-complet
 -+- x sur #ens-mim - codons porc -+-