[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH gnumach] ipc: warn about more port management bugs
From: |
Samuel Thibault |
Subject: |
Re: [PATCH gnumach] ipc: warn about more port management bugs |
Date: |
Thu, 22 Jan 2015 22:40:43 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Thu 22 Jan 2015 22:22:05 +0100, a écrit :
> + if (MACH_PORT_VALID (name) && space == current_space()) {
> printf("task %.*s destroying an invalid port %lu, most
> probably a bug.\n", sizeof current_task()->name, current_task()->name, name);
I'm a bit afraid of juxtaposing "PORT_VALID" and "invalid port", the
reader may get confused. Also change the warning wording into "a bogus
port", and then ack, thanks!
Samuel