Re: [SCM] glibc maintenance branch, t/mmap_file_prot_none_fix, created. glibc-2.17-767-gda2d6e6

[Thomas Schwinge]

Hi!

On Thu, 27 Feb 2014 20:02:04 +0000, Richard Braun <rbraun@sceen.net> wrote:
> This is an automated email from the git hooks/post-receive script. It was
> generated because a ref change was pushed to the repository containing
> the project "glibc maintenance".
> 
> The branch, t/mmap_file_prot_none_fix has been created
>         at  da2d6e677ade278bf34afaa35c6ed4ff2489e7d8 (commit)

Thanks for that!

Just pushed a small cleanup patch:

commit 466baaa005dc208924caedd7ebf55239cd27757b
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Fri Jan 23 14:57:31 2015 +0100

    Help the compiler by marking an unreachable code path.
    
    ... to avoid a warning:
    
        ../sysdeps/mach/hurd/mmap.c:145:7: warning: 'memobj' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
    
        * sysdeps/mach/hurd/mmap.c (__mmap): Mark the default case
        unreachable.
---
 sysdeps/mach/hurd/mmap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git sysdeps/mach/hurd/mmap.c sysdeps/mach/hurd/mmap.c
index b947815..e6e3643 100644
--- sysdeps/mach/hurd/mmap.c
+++ sysdeps/mach/hurd/mmap.c
@@ -104,7 +104,6 @@ __mmap (__ptr_t addr, size_t len, int prot, int flags, int 
fd, off_t offset)
             implementations take into account whether the mapping is
             anonymous or not when selecting addresses.  */
          case PROT_NONE:
-
          case PROT_READ:
            memobj = robj;
            if (wobj != MACH_PORT_NULL)
@@ -134,6 +133,8 @@ __mmap (__ptr_t addr, size_t len, int prot, int flags, int 
fd, off_t offset)
                return (__ptr_t) (long int) __hurd_fail (EACCES);
              }
            break;
+         default:
+           __builtin_unreachable ();
          }
        break;
        /* XXX handle MAP_NOEXTEND */


Grüße,
 Thomas

signature.asc
Description: PGP signature