[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3)
From: |
Svante Signell |
Subject: |
Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3) |
Date: |
Tue, 30 Aug 2016 23:38:19 +0200 |
On Tue, 2016-08-30 at 23:21 +0200, Samuel Thibault wrote:
> Svante Signell, on Tue 30 Aug 2016 17:40:00 +0200, wrote:
> >
> > Attached is an updated patch returning also EINVAL if abs(delta) is too
> > large.
> Never mix changes, please.
>
> >
> > Whether the adjtime()/RPC_host_adjust_time.c:___host_adjust_time() survives
> > a
> > delta being NULL remains to test.
> Well, there is no need to test::)
>
> *(time_value_t *) delta,
>
> will just crash.
How probable is this kind of (misuse) of this function? Nevertheless, maybe we
could use another dummy struct timespec (or the one already available)?
> >
> > According to the manpage the bug was:
> Again, note that manpages are often talking about the Linux
> implementation only :)
>
> We should probably try to implement the delta==NULL feature, though.
>
> Thanks for the patch,
Your'e welcome ;)
- RFC: [PATCH] Enable olddelta to be NULL in adjtime(3), Svante Signell, 2016/08/30
- RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Svante Signell, 2016/08/31
- Re: RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Samuel Thibault, 2016/08/31
- Re: RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Svante Signell, 2016/08/31
- Re: RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Samuel Thibault, 2016/08/31
- Re: RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Svante Signell, 2016/08/31
- Re: RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Samuel Thibault, 2016/08/31
- Re: RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Svante Signell, 2016/08/31
- Re: RFC: [PATCH] Fix setpriority calling __task_priority() for processes instead of threads., Samuel Thibault, 2016/08/31
Re: RFC: [PATCH] Enable olddelta to be NULL in adjtime(3), Samuel Thibault, 2016/08/30