[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] lwip: Call if_change_flags() inside a thread-safe contex
From: |
Joan Lledó |
Subject: |
Re: [PATCH 4/4] lwip: Call if_change_flags() inside a thread-safe context |
Date: |
Fri, 3 May 2019 13:37:59 +0200 |
Missatge de Samuel Thibault <samuel.thibault@gnu.org> del dia dv., 3
de maig 2019 a les 0:02:
> In C, there is no need to explicit the cast from void*.
I'm doing a similar cast on lwip-util.c:256. Should I remove it too?
> Errno is a per-thread variable, you can not propagate the error this
> way. You can for instance add an int field to if_change_flags_args, to
> read it from if_change_flags and freeing it there.
Totally true, I forgot it.
If I add an output parameter to *args, then I need to wait for the
callback to finish before freeing *args. Because tcpip_callback()
returns immediatelly.
I'll try to find the way to wait for _ if_change_flags() to finish,
I'll do it also for the patch 3.
[PATCH 4/4] lwip: Call if_change_flags() inside a thread-safe context, Joan Lledó, 2019/05/02
[PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Joan Lledó, 2019/05/02
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Samuel Thibault, 2019/05/02
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Samuel Thibault, 2019/05/02
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Joan Lledó, 2019/05/03
- Re: [PATCH 1/4] lwip: Fix bug: Remove unsupported flags when calling send()., Samuel Thibault, 2019/05/03
- [PATCH 2/2] lwip: Fix bug: Clear MSG_NOSIGNAL flag when calling send()., Joan Lledó, 2019/05/04
- [PATCH 2/2] lwip: Fix bug: Clear MSG_NOSIGNAL flag when calling send()., Joan Lledó, 2019/05/04
- Re: [PATCH 2/2] lwip: Fix bug: Clear MSG_NOSIGNAL flag when calling send()., Samuel Thibault, 2019/05/04
[PATCH 3/4] lwip: Error handling when calling update_if(), Joan Lledó, 2019/05/02