[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libfshelp: use FSHELP_EXTERN_INLINE
From: |
Samuel Thibault |
Subject: |
Re: [PATCH] libfshelp: use FSHELP_EXTERN_INLINE |
Date: |
Sat, 31 Oct 2020 12:17:28 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Romain Naour, le sam. 31 oct. 2020 10:33:47 +0100, a ecrit:
> Le 31/10/2020 à 00:04, Samuel Thibault a écrit :
> > Hello,
> >
> > Romain Naour, le ven. 30 oct. 2020 22:37:25 +0100, a ecrit:
> >> libfshelp/rlock.h and libfshelp/fshelp.h use FSHELP_EXTERN_INLINE
> >> not FSHELP_DEFINE_EXTERN_INLINE.
> >>
> >> * libfshelp/fshelp.h: Use FSHELP_EXTERN_INLINE, not
> >> FSHELP_DEFINE_EXTERN_INLINE.
> >
> > But FSHELP_EXTERN_INLINE is always getting defined, so that makes the
> > #if moot.
>
> Indeed.
>
> At first look the commit [1] seemed to me to introduce a typo
> FSHELP_DEFINE_EXTERN_INLINE instead of FSHELP_EXTERN_INLINE.
>
> >
> > I'd say rather make libfshelp/fshelp.h and libfshelp/extern-inline.c
> > coherent with libdiskfs's way of using FOO_DEFINE_EXTERN_INLINE. Others
> > (ext2fs, libpipe, etc.) are doing the same.
>
> You mean using FSHELP_DEFINE_EI and FSHELP_EI ?
No, I mean doing things similarly: really use
FSHELP_DEFINE_EXTERN_INLINE, instead of mixing
FSHELP_DEFINE_EXTERN_INLINE and FSHELP_EXTERN_INLINE.
Samuel