[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] rumpdisk: Don't pretend to be the arbiter anymore
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 4/4] rumpdisk: Don't pretend to be the arbiter anymore |
Date: |
Mon, 8 Mar 2021 22:29:07 +0100 |
User-agent: |
NeoMutt/20170609 (1.8.3) |
Damien Zammit, le mar. 09 mars 2021 00:04:57 +1100, a ecrit:
> @@ -164,6 +165,15 @@ rumpdisk_device_init (void)
> return;
> }
> }
> +
> + /* FIXME: need to synchronise with arbiter to wait for fsys_startup */
> + sleep(1);
Such hacks tend to break :)
> + task_get_bootstrap_port (mach_task_self (), &bootport);
> + fsys_getpriv (bootport, &_hurd_host_priv, &_hurd_device_master, &fstask);
Was the reason for the sleep the time to get bootport?
I'd say we can live with a while loop that tries to call
task_get_bootstrap_port and sleeps+repeats if it gets a null port.
> + sleep(1);
Is that one needed?
> rump_init ();
Samuel
- [PATCH hurd x4] - Working arbiter + rumpdisk, Damien Zammit, 2021/03/08
- [PATCH 1/4] acpi: Fix brokenness, Damien Zammit, 2021/03/08
- [PATCH 3/4] pci-arbiter: Introduce machdev into this server, Damien Zammit, 2021/03/08
- [PATCH 4/4] rumpdisk: Don't pretend to be the arbiter anymore, Damien Zammit, 2021/03/08
- Re: [PATCH 4/4] rumpdisk: Don't pretend to be the arbiter anymore,
Samuel Thibault <=
- [PATCH 2/4] pci-arbiter: Fix brokenness, Damien Zammit, 2021/03/08
- Re: [PATCH hurd x4] - Working arbiter + rumpdisk OFF TOPIC PRAISE, Joshua Branson, 2021/03/08