Re: [PATCH 2/5] libacpica: Add config for GNU

[Samuel Thibault]

Samuel Thibault, le sam. 03 avril 2021 14:41:59 +0200, a ecrit:
> Damien Zammit, le sam. 03 avril 2021 23:16:32 +1100, a ecrit:
> > +#define acpi_semaphore                      sem_t*
> 
> ? Rather a sem_t, no ? Otherwise you have to uselessly handle
> allocations etc. while the caller can do it.

+acpi_os_wait_semaphore(acpi_semaphore handle, u32 units, u16 timeout)

Ah, no, ok, it's really meant to be a handle, so yes you have to make it
a *.

> > +#define acpi_spinlock                       sem_t*

But for this one I believe it should be a sem_t, since:

acpi_os_create_lock(acpi_spinlock *lockp)

a pointer to it is given.

Samuel