Re: [PATCH 2/5 gnumach] i386: Refactor int stacks to be per cpu for SMP

[Samuel Thibault]

Hello,

Damien Zammit, le mer. 01 févr. 2023 10:05:47 +0000, a ecrit:
> This is a rather large commit, but difficult to break it up.

Perhaps you can separate out the moving of the i386at_init code

> @@ -448,47 +444,8 @@ i386at_init(void)
>        */
>       biosmem_setup();
> 
> -     /*
> -      * We'll have to temporarily install a direct mapping
> -      * between physical memory and low linear memory,
> -      * until we start using our new kernel segment descriptors.
> -      */
> -#if INIT_VM_MIN_KERNEL_ADDRESS != LINEAR_MIN_KERNEL_ADDRESS
> -     vm_offset_t delta = INIT_VM_MIN_KERNEL_ADDRESS - 
> LINEAR_MIN_KERNEL_ADDRESS;
> -     if ((vm_offset_t)(-delta) < delta)
> -             delta = (vm_offset_t)(-delta);
> -     int nb_direct = delta >> PDESHIFT;
> -     for (i = 0; i < nb_direct; i++)
> -             kernel_page_dir[lin2pdenum_cont(INIT_VM_MIN_KERNEL_ADDRESS) + 
> i] =
> -                     
> kernel_page_dir[lin2pdenum_cont(LINEAR_MIN_KERNEL_ADDRESS) + i];

[etc.]

into functions?

Samuel