[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cpu_number: Short circuit if smp init not done
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH] cpu_number: Short circuit if smp init not done |
|
Date: |
Sat, 4 Feb 2023 08:56:57 +0100 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Damien Zammit, le sam. 04 févr. 2023 03:30:45 +0000, a ecrit:
> This depends on serialised AP init patch.
>
> Fixes warnings spewing at boot with APIC and SMP
> ---
> i386/i386/cpu_number.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/i386/i386/cpu_number.c b/i386/i386/cpu_number.c
> index ad4c4b01..eca95d7a 100644
> --- a/i386/i386/cpu_number.c
> +++ b/i386/i386/cpu_number.c
> @@ -21,10 +21,16 @@
> #include <i386/cpu.h>
> #include <kern/printf.h>
>
> +extern int bspdone;
Please avoid introducing more such in-C extern declarations. We want
them in headers.
Samuel