Re: [PATCH 1/6] set unused members of thread state to 0

[Samuel Thibault]

Better avoid uninitialized data indeed, applied, thanks!

Luca Dariz, le dim. 12 févr. 2023 18:03:08 +0100, a ecrit:
> * i386/i386/pcb.c: always set esp to 0, it  seems unused.
> ---
>  i386/i386/pcb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/i386/i386/pcb.c b/i386/i386/pcb.c
> index 9ac55a1c..924ed08b 100644
> --- a/i386/i386/pcb.c
> +++ b/i386/i386/pcb.c
> @@ -706,6 +706,7 @@ kern_return_t thread_getstatus(
>               state->eip = saved_state->eip;
>               state->efl = saved_state->efl;
>               state->uesp = saved_state->uesp;
> +             state->esp = 0;  /* unused */
>  
>               state->cs = saved_state->cs;
>               state->ss = saved_state->ss;
> -- 
> 2.30.2
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.