Re: [RFC PATCH gnumach 02/34] Remove bootstrap.defs

[Samuel Thibault]

Hello,

I guess the do_bootstrap_privileged_ports function can be dropped from
the hurd repo?

Applied, thanks!

Samuel

Sergey Bugaev, le dim. 19 mars 2023 18:09:45 +0300, a ecrit:
> As far as I can see, this file was imported in the very beginning of GNU Mach
> history, and unused since then. Nobody implements or uses this interface. GNU
> Mach uses a different way to pass the privileged ports to the bootstrap tasks:
> instead of the task(s) actively asking for the ports in an RPC, the ports are
> preemptively inserted into the IPC space(s) of the task(s), as configured by
> the boot script.
> 
> Remove bootstrap.defs so as to not confuse anyone into thinking it works.
> ---
>  Makefrag.am                 |  1 -
>  include/mach/bootstrap.defs | 49 -------------------------------------
>  2 files changed, 50 deletions(-)
>  delete mode 100644 include/mach/bootstrap.defs
> 
> diff --git a/Makefrag.am b/Makefrag.am
> index 358f8db3..5d4f2c48 100644
> --- a/Makefrag.am
> +++ b/Makefrag.am
> @@ -367,7 +367,6 @@ include_device_HEADERS = \
>  
>  include_machdir = $(includedir)/mach
>  include_mach_HEADERS = \
> -     include/mach/bootstrap.defs \
>       include/mach/default_pager.defs \
>       include/mach/default_pager_helper.defs \
>       include/mach/default_pager_types.defs \
> diff --git a/include/mach/bootstrap.defs b/include/mach/bootstrap.defs
> deleted file mode 100644
> index 0b233e4a..00000000
> --- a/include/mach/bootstrap.defs
> +++ /dev/null
> @@ -1,49 +0,0 @@
> -/* 
> - * Mach Operating System
> - * Copyright (c) 1992 Carnegie Mellon University
> - * All Rights Reserved.
> - * 
> - * Permission to use, copy, modify and distribute this software and its
> - * documentation is hereby granted, provided that both the copyright
> - * notice and this permission notice appear in all copies of the
> - * software, derivative works or modified versions, and any portions
> - * thereof, and that both notices appear in supporting documentation.
> - * 
> - * CARNEGIE MELLON ALLOWS FREE USE OF THIS SOFTWARE IN ITS "AS IS"
> - * CONDITION.  CARNEGIE MELLON DISCLAIMS ANY LIABILITY OF ANY KIND FOR
> - * ANY DAMAGES WHATSOEVER RESULTING FROM THE USE OF THIS SOFTWARE.
> - * 
> - * Carnegie Mellon requests users of this software to return to
> - * 
> - *  Software Distribution Coordinator  or  Software.Distribution@CS.CMU.EDU
> - *  School of Computer Science
> - *  Carnegie Mellon University
> - *  Pittsburgh PA 15213-3890
> - * 
> - * any improvements or extensions that they make and grant Carnegie Mellon 
> - * the rights to redistribute these changes.
> - */
> -
> -subsystem bootstrap 999999;
> -
> -#include <mach/std_types.defs>
> -
> -ServerPrefix do_;
> -
> -/*
> - *   The old form of the bootstrap_privileged_ports RPC
> - *   is not expressible in Mig syntax, because the reply
> - *   message doesn't have a return code.
> - */
> -
> -skip;        /* old bootstrap_privileged_ports */
> -
> -/*
> - *   The startup task can make this call on its bootstrap port
> - *   to get the privileged ports.
> - */
> -
> -routine bootstrap_privileged_ports(
> -             bootstrap               : mach_port_t;
> -     out     priv_host               : mach_port_t;
> -     out     priv_device             : mach_port_t);
> -- 
> 2.39.2
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.