Re: [RFC PATCH glibc 13/34] x86-64: Disable prefer_map_32bit_exec tunable on non-Linux

[Samuel Thibault]

Hello,

Sergey Bugaev, le dim. 19 mars 2023 18:09:56 +0300, a ecrit:
> While we could/should implement MAP_32BIT for the Hurd port by setting
> all the high bits of mask in a vm_map () call, neither MAP_32BIT nor
> glibc.cpu.prefer_map_32bit_exec exist on the Hurd as of now. Compile
> this code out to fix build failures.

Rather use defined(MAP_32BIT)? That way it will nicely work for BSD
ports as well, and when hurd eventually supports MAP_32BIT.

> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
> ---
>  sysdeps/x86/cpu-features.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c
> index 822688e2..78631d7a 100644
> --- a/sysdeps/x86/cpu-features.c
> +++ b/sysdeps/x86/cpu-features.c
> @@ -27,7 +27,7 @@
>  extern void TUNABLE_CALLBACK (set_hwcaps) (tunable_val_t *)
>    attribute_hidden;
>  
> -# ifdef __LP64__
> +# if defined (__LP64__) && defined (__linux__)
>  static void
>  TUNABLE_CALLBACK (set_prefer_map_32bit_exec) (tunable_val_t *valp)
>  {
> @@ -715,7 +715,7 @@ no_cpuid:
>  #if HAVE_TUNABLES
>    TUNABLE_GET (hwcaps, tunable_val_t *, TUNABLE_CALLBACK (set_hwcaps));
>  
> -# ifdef __LP64__
> +# if defined (__LP64__) && defined (__linux__)
>    TUNABLE_GET (prefer_map_32bit_exec, tunable_val_t *,
>              TUNABLE_CALLBACK (set_prefer_map_32bit_exec));
>  # endif
> -- 
> 2.39.2
>