Re: [RFC PATCH glibc 16/34] hurd: Add sys/ucontext.h and sigcontext.h for x86_64

[Sergey Bugaev]

On Mon, Apr 10, 2023, 21:39 Samuel Thibault <samuel.thibault@gnu.org> wrote:
>
> Hello,
>
> Applied, thanks!

Yay! Thank you for finding the time to review some more patches!
Here's to hoping that the rest will follow.

> Note that I have pushed sysdeps/mach/hurd/x86_64/sys/ucontext.h to
> sysdeps/x86_64/sys/ucontext.h since it's not mach-specific, and Linux
> has its own for x86.

It's not technically Mach specific, but it's arranged the same way as
Mach's struct i386_thread_state, and code in hurdsig.c relies on this.
If, say, Flavio would have arranged registers differently in gnumach
commit feba9b7b1d88e505feb6579e41dc45e48c264e6f — say, put rdi & rsi
before the r{8..15} gang, like it's done in the 32-bit version — then
ucontext definitions would also have to be different. So while it
could work for any port (provided it doesn't care about the ordering),
putting it into the generic tree underemphasizes why it has to be
arranged this specifically.

But it's up to you, of course.

Sergey