Re: [PATCH 2/5] hurd: Microoptimize sigreturn

[Samuel Thibault]

Hello,

Sergey Bugaev, le ven. 14 avril 2023 22:36:57 +0300, a ecrit:
> -  struct hurd_sigstate *ss = _hurd_self_sigstate ();
> +  struct hurd_sigstate *ss;
> +
> +  /* We know the sigstate must be initialized,

That doesn't seem to be true, we get segfaults with this patch applied
in these tests:

./htl/tst-kill6.test-result:FAIL: htl/tst-kill6
./htl/tst-pt-tls2.test-result:FAIL: htl/tst-pt-tls2

#0  0x0105a7c2 in sigstate_is_global_rcv (ss=0x0) at hurdsig.c:183
183              && (ss->actions[0].sa_handler == SIG_IGN);
(gdb) bt
#0  0x0105a7c2 in sigstate_is_global_rcv (ss=0x0) at hurdsig.c:183
#1  __GI__hurd_sigstate_lock (ss=0x0) at hurdsig.c:192
#2  0x0108bb17 in __sigreturn (scp=0x2104bec) at 
../sysdeps/mach/hurd/i386/sigreturn.c:94
#3  0x010602f6 in trampoline () from ./libc.so.0.3

Samuel