Re: [RFC PATCH 1/5] misc: Convert daemon () to GNU coding style

[Adhemerval Zanella Netto]

On 18/04/23 10:48, Cristian Rodríguez wrote:
> 
> 
> On Tue, Apr 18, 2023 at 8:02 AM Adhemerval Zanella Netto via Libc-alpha 
> <libc-alpha@sourceware.org <mailto:libc-alpha@sourceware.org>> wrote:
> 
> 
> 
>     On 17/04/23 19:58, Sergey Bugaev via Libc-alpha wrote:
>     > This is nicer, and is going to be required for the following changes
>     > to reasonably stay within the 79 column limit.
>     >
>     > No functional change.
>     >
>     > Signed-off-by: Sergey Bugaev <bugaevc@gmail.com 
> <mailto:bugaevc@gmail.com>>
> 
>     LGTM, some minor nits below.
> 
>     > ---
>     >  misc/daemon.c | 88 ++++++++++++++++++++++++++++-----------------------
>     >  1 file changed, 49 insertions(+), 39 deletions(-)
>     >
>     > diff --git a/misc/daemon.c b/misc/daemon.c
>     > index 3c73ac2a..61da49b7 100644
>     > --- a/misc/daemon.c
>     > +++ b/misc/daemon.c
>     > @@ -43,50 +43,60 @@ static char sccsid[] = "@(#)daemon.c      8.1 
> (Berkeley) 6/4/93";
> 
> 
>     I think there is no need to ignore return code.
> 
> 
> Also This code clearly comes from freeBSD.. which has since updated the code 
> to ignore SIGHUP  when the parent exits.
> 
> https://web.mit.edu/freebsd/head/lib/libc/gen/daemon.c 
> <https://web.mit.edu/freebsd/head/lib/libc/gen/daemon.c>

I think such change should be in a different patch though.