bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] fix exception message format for 64-bit userspace


From: Luca Dariz
Subject: Re: [PATCH 3/5] fix exception message format for 64-bit userspace
Date: Thu, 20 Apr 2023 21:34:52 +0200

Hi Flavio,

Il 20/04/23 04:04, Flávio Cruz ha scritto:
On Wed, Apr 19, 2023 at 3:47 PM Luca Dariz <luca@orpolo.org <mailto:luca@orpolo.org>> wrote:

    * kern/exception.c: message fields need to be aligned to 8 bytes for a
       64-bit userspace, so add the required padding if needed, as done by
       MIG.

I believe this shouldn't be necessary due to https://git.savannah.gnu.org/cgit/hurd/gnumach.git/commit/?id=8e5e86fc13732b60d2e4d14152d92db1f1ae73f9 <https://git.savannah.gnu.org/cgit/hurd/gnumach.git/commit/?id=8e5e86fc13732b60d2e4d14152d92db1f1ae73f9> which forces mach_msg_type_t to always be 8 byte aligned. If you check the size before and after your patch, it will be the same.

you're right, I must have made this change before this commit.


Luca



reply via email to

[Prev in Thread] Current Thread [Next in Thread]